Infra: Replace deprecated utcnow and utcfromtimestamp #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
approved these changes
May 16, 2023
|
Nice. Do we know what minimum Python version we're targeting for building PEPs? IMO it wouldn't be a problem to demand a semi-current version, since the small number of people for whom Python X.Y isn't easily available can still post PRs (they'll just have to wait for CI before knowing that the PEP built correctly). |
|
Seems like we need 3.11+ |
|
Python 3.9 is the minimum tested on the CI, because we use some type annotations not available on 3.8 and earlier. |
AA-Turner
approved these changes
May 17, 2023
hugovk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime.datetime.utcnowanddatetime.datetime.utcfromtimestampraise deprecation warnings in Python 3.12: python/cpython#103857.datetime.UTCis a (new in 3.11) alias of the olderdatetime.timezone.utc, but I think we want to keep support for older versions here, to make things easier for PEP authors.https://docs.python.org/3/library/datetime.html#datetime.UTC
📚 Documentation preview 📚: https://pep-previews--3148.org.readthedocs.build/