Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 744: Additional updates from discussion thread #3861

Merged
merged 15 commits into from
Aug 9, 2024

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Jul 11, 2024

This PR addresses some additional comments from #3850 (review). I've chosen to address the comment around the JIT environment variable in the JIT's README (see python/cpython#121635) since I think that's maybe valuable to contributors and that file is linked from the PEP.

I've also added myself to CODEOWNERS for this file.


📚 Documentation preview 📚: https://pep-previews--3861.org.readthedocs.build/

peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
savannahostrowski and others added 4 commits July 11, 2024 16:43
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! A few thoughts I had while reading through:

peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
peps/pep-0744.rst Outdated Show resolved Hide resolved
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@brandtbucher brandtbucher merged commit a9242b6 into python:main Aug 9, 2024
6 checks passed
@willingc
Copy link
Contributor

willingc commented Aug 9, 2024

Nice work @savannahostrowski.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants