Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 710: state download_info structure used in pip #3880

Closed
wants to merge 1 commit into from

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Jul 30, 2024


📚 Documentation preview 📚: https://pep-previews--3880.org.readthedocs.build/

Signed-off-by: Fridolin Pokorny <fridolin.pokorny@gmail.com>
@fridex
Copy link
Contributor Author

fridex commented Jul 30, 2024

@sbidoul @pfmoore @sethmlarson following discussion in pypa/pip#11865 (comment), I was not sure about the phrasing here, also whether this should go to the specification section. Any suggestions are welcome.

@pfmoore
Copy link
Member

pfmoore commented Jul 30, 2024

I'm a strong -1 on the standard special casing pip in any way.

@fridex
Copy link
Contributor Author

fridex commented Jul 30, 2024

I'm a strong -1 on the standard special casing pip in any way.

Okay, sounds reasonable.

Addressing comment pypa/pip#11865 (comment), @sbidoul Is it okay if we keep PEP as-is with the generic cache note, without stating the download_info structure? Maybe I missed something here otherwise.

@pfmoore
Copy link
Member

pfmoore commented Jul 30, 2024

Please raise this on Discourse, and in particular get input from the uv developers, who aggressively cache a lot of things for performance, and for whom this requirement might be problematic.

@fridex
Copy link
Contributor Author

fridex commented Jul 30, 2024

Please raise this on Discourse, and in particular get input from the uv developers, who aggressively cache a lot of things for performance, and for whom this requirement might be problematic.

They were notified in astral-sh/uv#5627

As we do not want to have pip-specific parts in the specification, closing this PR, and let's continue with the discussion on Discourse.

@fridex fridex closed this Jul 30, 2024
@fridex fridex deleted the pep-710-download-info-structure branch July 30, 2024 18:57
@sbidoul
Copy link
Contributor

sbidoul commented Aug 1, 2024

Addressing comment pypa/pip#11865 (comment), @sbidoul Is it okay if we keep PEP as-is with the generic cache note, without stating the download_info structure? Maybe I missed something here otherwise.

@fridex sure, I also think it's better not to mention download_info in the PEP, as that is pip-specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants