-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 752: Package repository namespaces #3903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first draft @ofek, thank you. I have left a bunch of comments and replies to @AA-Turner 's comments too.
One thing that is unclear to me (perhaps I need to re-read), is exactly how a grant request is initiated. Is it through a package upload, via UI request on an org page, through an API call, etc.?
I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofek there is one question still unresolved. If you could answer that, I will resolve the conversation and this can be published.
Thank you! I responded to that feedback and pushed a final commit to improve the name of a section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorially, looks good.
A
Updating discussion history: #3911 |
It seems codespell was last run on peps up to around 481 since there's only one typo up to pep 100 and many thereafter. Run precommit Fix false positive, thanks @Rosuav Add loath to excludes Fix underline too short PEP 752: Package repository namespaces (python#3903) PEP 752: Package repository namespaces --------- Co-authored-by: Barry Warsaw <barry@python.org> PEP 752: Update discussion history (python#3911) Add emtpy line ending, thanks @AA-Turner
pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriate.github/CODEOWNERS
for the PEPPython-Version
set to valid (pre-beta) future Python version, if relevantDiscussions-To
andPost-History
📚 Documentation preview 📚: https://pep-previews--3903.org.readthedocs.build/pep-0752/