Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 752: Package repository namespaces #3903

Merged
merged 8 commits into from
Aug 18, 2024
Merged

PEP 752: Package repository namespaces #3903

merged 8 commits into from
Aug 18, 2024

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 13, 2024

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP
  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--3903.org.readthedocs.build/pep-0752/

@ofek ofek requested a review from a team as a code owner August 13, 2024 17:00
@ofek ofek changed the title PEP 752: Package repository namespacing PEP 752: Package repository namespaces Aug 13, 2024
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments

peps/pep-0752.rst Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first draft @ofek, thank you. I have left a bunch of comments and replies to @AA-Turner 's comments too.

One thing that is unclear to me (perhaps I need to re-read), is exactly how a grant request is initiated. Is it through a package upload, via UI request on an org page, through an API call, etc.?

peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
peps/pep-0752.rst Outdated Show resolved Hide resolved
@ofek
Copy link
Contributor Author

ofek commented Aug 14, 2024

One thing that is unclear to me (perhaps I need to re-read), is exactly how a grant request is initiated. Is it through a package upload, via UI request on an org page, through an API call, etc.?

I added a Submission section that is explicit about the process being through a form in the app!

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofek there is one question still unresolved. If you could answer that, I will resolve the conversation and this can be published.

@ofek
Copy link
Contributor Author

ofek commented Aug 17, 2024

Thank you! I responded to that feedback and pushed a final commit to improve the name of a section.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially, looks good.

A

@warsaw warsaw merged commit 9247c98 into python:main Aug 18, 2024
6 checks passed
@ofek ofek deleted the namespaces branch August 18, 2024 19:10
@ofek
Copy link
Contributor Author

ofek commented Aug 18, 2024

Updating discussion history: #3911

corneliusroemer added a commit to corneliusroemer/peps that referenced this pull request Aug 19, 2024
It seems codespell was last run on peps up to around 481 since there's only one typo up to pep 100 and many thereafter.

Run precommit

Fix false positive, thanks @Rosuav

Add loath to excludes

Fix underline too short

PEP 752: Package repository namespaces (python#3903)

PEP 752: Package repository namespaces
---------

Co-authored-by: Barry Warsaw <barry@python.org>

PEP 752: Update discussion history (python#3911)

Add emtpy line ending, thanks @AA-Turner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants