Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive images on the planet #24

Closed
luzfcb opened this issue Feb 24, 2015 · 3 comments · Fixed by #25
Closed

Responsive images on the planet #24

luzfcb opened this issue Feb 24, 2015 · 3 comments · Fixed by #25

Comments

@luzfcb
Copy link
Contributor

luzfcb commented Feb 24, 2015

the current layout leaves very large images leak out of the visible area.
It is necessary, any change in the css to make the images are not outside the visible area

@rochacbruno
Copy link
Member

Everything posted to the planet is under the source formatting, the template in planet only takes the content of the feed and renders it directly

https://github.com/python/planet/blob/master/code/python/index.html.tmpl#L74

So it would be needed to add some css
Adding

img {
    border: 0;
    height: 100%;
    max-width: 100%;
}

should help, but only if images are included inside proper containers, as we cannot validate the html structure, maybe it will need some JavaScript to format the images.

@rochacbruno
Copy link
Member

I tested the solution proposed above, I will send a Pull Request for others to approve.

@rochacbruno
Copy link
Member

The solution on above PR fixes the size of big images, waiting for another member to review and merge.

rochacbruno added a commit that referenced this issue Feb 26, 2015
added in-head css styling to make images responsive fix #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants