Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

Removes local_settings template and config for pycon: #153

Closed
wants to merge 1 commit into from

Conversation

calebsmith
Copy link

This template and associated settings file aren't needed as the
production or staging settings files are used by manage.py from the
IS_PRODUCTION environment variable set in the environment elsewhere in
the recipe. Having this in place only leads to confusion.

Refers to PyCon/pycon2019#377

Also, just realizing I should probably remove the settings: bit from the django do entirely but unsure enough of how Chef uses these bits that I could use some guidance there. I was able to confirm on staging that the staging settings file was in fact being used and local_settings ignored.

This template and associated settings file aren't needed as the
production or staging settings files are used by manage.py from the
IS_PRODUCTION environment variable set in the environment elsewhere in
the recipe. Having this in place only leads to confusion.

Refs PyCon/pycon2019#377
@ewdurbin
Copy link
Member

@calebsmith thanks, i did the base work for moving this to our new infrastructure, and the psf-salt environment over the weekend.

it should be all set with a few more evenings of work, so there's no real worry to modify this chef cookbook unless it's blocking work for the team.

@calebsmith
Copy link
Author

ok, no problem. Was sort of finishing up from where I left off before a vacation. If that is in the works, we can close. This is sort of a "cleanup" task and not really blocking anything.

@ewdurbin
Copy link
Member

here is said work, @calebsmith

it covers a lot of your previous notes (up to date distro, no more running as root, etc) :)

@ewdurbin ewdurbin closed this Jul 28, 2015
@calebsmith calebsmith deleted the pycon_rm_local_settings branch July 28, 2015 17:07
@calebsmith
Copy link
Author

Ok, thanks @ewdurbin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants