Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate library/stdtypes.po rst: 205-895 #876

Merged
merged 15 commits into from
May 6, 2024

Conversation

beccalzh
Copy link
Collaborator

Little modification for..

  • 4. Comparisons

Add translations for..

  • 5. Boolean Types
  • 6. Numeric Types — int, float, complex

Someone who reviews this maight hate me, I am sorry for that :(

@mattwang44
Copy link
Collaborator

小建議:可以用 pre-commit 幫助斷行排版
image

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先看 CI failed 是否是因為這樣

library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先抓一些明顯的錯誤,下一輪 review 再看翻譯正確性。
一些語法或翻譯建議我只有指出一處,要請你也修正其他出現的地方 🙏🏽

library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
@beccalzh
Copy link
Collaborator Author

我發現幾個問題

  1. 翻譯的部分有很多高頻詞,such as integer, float etc. 這部分要附上原文嗎?
  2. 接續上一個問題。如果要附上原文,那如果像是floating-point numbersfloatfloating point都翻成浮點數的話,全部原文都寫浮點數嗎?

感恩Matt大大幫review~

@mattwang44
Copy link
Collaborator

只要在想附註原文的字詞首次出現之處附註原文即可,後面出現就不用再附註(modulocode point 等目前每個出現的地方都被附註了,但只要附註一次即可)

  1. 我認為不一定要翻譯,不翻譯的話也不一定要加註原文,單一頁文件內的翻譯習慣要統一即可(不要在譯文內同時混用 float浮點數)。
  2. 我覺得類似問題可能會需要視情況討論,但 float 一系列字詞我覺得可以不用加註原文

library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
@beccalzh
Copy link
Collaborator Author

我發現rst:322的內容好像有點不一樣,我local build的時候,那段中文也不會顯示出來 :(

html
Screenshot 2024-04-30 at 3 52 34 PM

po file
Screenshot 2024-04-30 at 3 53 05 PM

@mattwang44
Copy link
Collaborator

mattwang44 commented Apr 30, 2024

...那段中文也不會顯示出來 :(

不是你的問題歐,我操作也是這樣
html 上的字串和 po 上的原文不同,代表我們定期從 CPython repo 把文件原文拉過來的 cronjob 在 library/stdtypes.po 上失效(這是因為原文的 po template 有兩個 "values" 字串,導致處理 po 檔案的工具會噴錯誤)。我打算在這個 PR merge 後再來處理這個問題(如果覺得不舒服的話,你也可以嘗試研究看看怎麼處理XD)。

@beccalzh beccalzh changed the title 0426_stdtypes_5&6 Translate library/stdtypes.po rst: 205-895 May 2, 2024
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
@beccalzh
Copy link
Collaborator Author

beccalzh commented May 3, 2024

preview

Screenshot 2024-05-03 at 4 32 11 PM
Screenshot 2024-05-03 at 4 32 25 PM
Screenshot 2024-05-03 at 4 32 42 PM
Screenshot 2024-05-03 at 4 33 01 PM
Screenshot 2024-05-03 at 4 33 17 PM
Screenshot 2024-05-03 at 4 33 59 PM
Screenshot 2024-05-03 at 4 34 18 PM
Screenshot 2024-05-03 at 4 34 54 PM
Screenshot 2024-05-03 at 4 35 06 PM

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最後可以再做一下 formatting

library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
@beccalzh
Copy link
Collaborator Author

beccalzh commented May 6, 2024

Details

Screenshot 2024-05-06 at 9 48 01 AM
Screenshot 2024-05-06 at 9 48 19 AM
Screenshot 2024-05-06 at 9 48 32 AM
Screenshot 2024-05-06 at 9 48 47 AM
Screenshot 2024-05-06 at 9 49 11 AM
Screenshot 2024-05-06 at 9 49 27 AM
Screenshot 2024-05-06 at 9 49 41 AM
Screenshot 2024-05-06 at 9 49 55 AM
Screenshot 2024-05-06 at 9 50 09 AM

mattwang44
mattwang44 previously approved these changes May 6, 2024
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 剩兩個小問題,我直接 commit 進去
  • 新的 preview 好像沒有反映出有修正的地方

library/stdtypes.po Outdated Show resolved Hide resolved
library/stdtypes.po Outdated Show resolved Hide resolved
mattwang44
mattwang44 previously approved these changes May 6, 2024
@mattwang44 mattwang44 enabled auto-merge (squash) May 6, 2024 06:05
@mattwang44 mattwang44 merged commit 2b79bdc into python:3.12 May 6, 2024
1 check passed
@beccalzh beccalzh deleted the library/stdtypes2 branch September 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants