openpyxl: Class attributes set explicitly as another class' #10549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Avasam
changed the title
srittau
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has overlap with #9511, so should reduce changes there.
I searched the openpyxl source code for instances of a class attribute being explicitly set as another class'.
In most cases, those will be descriptors, which pyright will have issues with re-assigning. Luckily, they'll also mostly refer to parent definitions. For typing purposes, this can be simplified to just not including them. I still left them in as comments to make it a bit more explicit.
Similarly, mypy has issues with re-assigning properties (see python/mypy#13975 / python/mypy#6700) so I explicitly redefined those when they came from a non-parent class.