Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All locale functions should exist on macos #10805

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

sobolevn
Copy link
Member

I've seen the comment about this error being specific to GitHub Actions, but since it now not 3.10.5, but 3.10.13 we should try to remove these exceptions.

Local check:

>>> import locale
>>> locale.gettext('a')
'a'
>>> locale.bindtextdomain
<built-in function bindtextdomain>
>>> locale.bind_textdomain_codeset
<built-in function bind_textdomain_codeset>
>>> locale.dcgettext
<built-in function dcgettext>
>>> locale.dgettext
<built-in function dgettext>
>>> locale.gettext
<built-in function gettext>
>>> locale.textdomain
<built-in function textdomain>

@sobolevn
Copy link
Member Author

3.11 and 3.12 are still affected. Maybe this is a setup-python bug? 🤔

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a go! 🤞

@AlexWaygood AlexWaygood merged commit ec69d98 into main Sep 29, 2023
63 checks passed
@AlexWaygood AlexWaygood deleted the fix-locale-functions-macos branch September 29, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants