Avoid using new _typeshed protocol in pkg_resources for now
#11909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
May 12, 2024
There was a problem hiding this comment.
Maybe we should just put the non-_typeshed version of the protocol in stubs/setuptools/pkg_resources/__init__.pyi, if that's the only place it's used now? That would also mean we wouldn't need to noqa it.
Basically LGTM though, thanks! (I'm about to board my second flight of the day so if you want me to re-review it might not happen until tomorrow ;)
|
Have a safe flight! |
AlexWaygood
changed the title
types._LoaderProtocol in pkg_resources_typeshed protocol in pkg_resources for now
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #11890 (comment)
Must be kept until next mypy release.
CC @AlexWaygood or @srittau