Bump python-crontab to 3.1.* #12008
Merged
Bump python-crontab to 3.1.* #12008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
reviewed
May 23, 2024
| @@ -259,6 +259,7 @@ class CronSlice: | |||
| def __iter__(self) -> Iterator[int]: ... | |||
| def __len__(self) -> int: ... | |||
| def parse_value(self, val: str, sunday: int | None = ...) -> int | CronValue: ... | |||
| def test_value(self, value: str, sunday: int | None = None) -> str: ... | |||
There was a problem hiding this comment.
This is a weird one. In every() it's actually called with int. It seems we really need a type var here (bound to ConvertibleToInt).
There was a problem hiding this comment.
Let's maybe separate refactoring and a version bump? Let it be consistent with parse_value for now. There are lots of things to fix in this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12004