Use mypy from git for stdlib stubtest #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well the typeshed test errors are fixable, but I guess the stub uploader test failures are harder. It's unfortunate that they're so tightly coupled to our setup here in typeshed :( |
AlexWaygood
changed the title
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I updated the PR to only use mypy from git for |
JelleZijlstra
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a lot easier for new contributors to help out with updating typeshed to reflect the py313 changes. Otherwise there are many false positives in stubtest's output. Mypy has fixed these stubtest false positives on their master branch, but there hasn't yet been a release that includes them.