builtins: updates for py313 #12028
Merged
builtins: updates for py313 #12028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
stdlib/builtins.pyi
Outdated
| @@ -461,7 +461,11 @@ class str(Sequence[str]): | |||
| def format(self: LiteralString, *args: LiteralString, **kwargs: LiteralString) -> LiteralString: ... | |||
| @overload | |||
| def format(self, *args: object, **kwargs: object) -> str: ... | |||
| def format_map(self, map: _FormatMapMapping) -> str: ... | |||
| if sys.version_info >= (3, 13): | |||
| def format_map(self, /, mapping: _FormatMapMapping) -> str: ... | |||
There was a problem hiding this comment.
Are you sure?
% ./python.exe
Python 3.14.0a0 (heads/pep649-inspect-dirty:f9b395687e, May 24 2024, 10:50:24) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> "x".format_map(mapping={})
Traceback (most recent call last):
File "<python-input-0>", line 1, in <module>
"x".format_map(mapping={})
~~~~~~~~~~~~~~^^^^^^^^^^^^
TypeError: str.format_map() takes no keyword arguments
Apparently the docstring says it's a pos-or-keyword, but that's a lie; it's defined as METH_O and therefore takes only a positional argument. https://github.com/python/cpython/blob/cc38ee1edb029d7a9d2c39f8eac0bdff74549988/Objects/unicodeobject.c#L13537
There was a problem hiding this comment.
Gah... serves me right for believing stubtest, I suppose? We'd better fix that upstream.
There was a problem hiding this comment.
| @@ -2057,3 +2074,7 @@ if sys.version_info >= (3, 11): | |||
| def split( | |||
| self, condition: Callable[[_ExceptionT_co | Self], bool], / | |||
| ) -> tuple[ExceptionGroup[_ExceptionT_co] | None, ExceptionGroup[_ExceptionT_co] | None]: ... | |||
|
|
|||
| if sys.version_info >= (3, 13): | |||
| class IncompleteInputError(SyntaxError): ... | |||
| @@ -1214,6 +1224,9 @@ class property: | |||
| fset: Callable[[Any, Any], None] | None | |||
| fdel: Callable[[Any], None] | None | |||
| __isabstractmethod__: bool | |||
| if sys.version_info >= (3, 13): | |||
| __name__: str | |||
There was a problem hiding this comment.
This isn't in https://docs.python.org/3.13/whatsnew/3.13.html, it probably should be.
JelleZijlstra
approved these changes
May 24, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.