Add BaseException.__new__
#12346
Merged
Add BaseException.__new__
#12346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
It seems that pyright does not like the mismatch between |
|
That seems to reduce the amount of errors but a lot of them still remain (I pushed the change so that you can see for yourself) |
This comment has been minimized.
This comment has been minimized.
|
I'm a bit unsure how to proceed here. The stubs now seem to match the implementation. I'm not sure why pyright complains. |
|
I'm as stumped as you are 😅 |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jul 21, 2024
max-muoto
pushed a commit
to max-muoto/typeshed
that referenced
this pull request
Jul 23, 2024
max-muoto
pushed a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12231
I think this is the correct signature given the definition:
https://github.com/python/cpython/blob/65fededf9cc1780d5edbef8a6e0a7cf9bc15aea6/Objects/exceptions.c#L43-L69