markdown: Add missing attribute to Markdown stub. #5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your diff adds it as an argument to |
akshatdalton
force-pushed
the
missing_attribute
branch
from
05f58a4
to
6ac17da
Compare
|
Added the changes in the new commit. |
|
Your diff still adds it as an argument to |
akshatdalton
force-pushed
the
missing_attribute
branch
from
6ac17da
to
ddb129f
Compare
|
Yeah, right. I don't know how I forgot to change the main subject. 🤦 |
srittau
approved these changes
May 28, 2021
Akuli
reviewed
May 29, 2021
Akuli
reviewed
May 29, 2021
Akuli
approved these changes
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a regular contributor @zulip, and I've added a commit that overrides the
_parseHeaderfunction, and while working, I found that this attribute is missing here. (Related PR: zulip/zulip#18608)This attribute is defined here: https://github.com/Python-Markdown/markdown/blob/3ea29f9d9b7d201269444dccedc0383065532b7e/markdown/extensions/codehilite.py#L113.