Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party stubs: audit Callable[<parameters>, None] annotations #8175

Merged
merged 3 commits into from
Jun 26, 2022

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 26, 2022

All of these callbacks have return values that are ignored at runtime.

Relevant to PyCQA/flake8-pyi/issues/237 (I was already looking at this before the issue was filed ;)

@github-actions

This comment has been minimized.

stubs/pynput/pynput/_util.pyi Outdated Show resolved Hide resolved
stubs/waitress/waitress/utilities.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@AlexWaygood AlexWaygood requested a review from srittau June 26, 2022 11:56
@srittau srittau merged commit 74bd0d9 into python:master Jun 26, 2022
@AlexWaygood AlexWaygood deleted the callbacks branch June 26, 2022 11:56
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants