Improve xmlrpc.client callbacks
#8188
Conversation
This comment has been minimized.
This comment has been minimized.
stdlib/xmlrpc/client.pyi
Outdated
| # TODO: Replace 'Any' with some kind of binding | ||
| dispatch: dict[type[Any], Callable[[Marshaller, Any, _WriteType], None]] |
There was a problem hiding this comment.
Just use _typeshed.Incomplete instead of Any, in case this is potentially fixable.
There was a problem hiding this comment.
I had a look at the source code writing this PR, and I get what the comment is saying, but I don't think it's really fixable tbh.
I'm wondering if we should introduce _typeshed.Inexpressible for cases like this, where we know what the type should be (so it's not incomplete per se), it's just that we don't currently have any way of expressing it in the current type system. It might also be useful for places where we really need recursive type aliases, but can't use them yet.
There was a problem hiding this comment.
Well, Inexpressible is basically Any, at least if we use Incomplete consistently.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Relevant to PyCQA/flake8-pyi/issues/237