-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PEP number for TypeAlias
.
#1008
Conversation
Per the Python docs and PEPs, `TypeAlias` appears to have been defined in PEP 613, not PEP 610. https://docs.python.org/3/library/typing.html#relevant-peps https://www.python.org/dev/peps/pep-0613/ PEP 610 is titled "Recording the Direct URL Origin of installed distributions" and does not appear related to `TypeAlias`.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
While I don't believe we need CLA approval for this simple change, I don't want to merge this as a non-member of the PSF. You might look into signing the CLA anyway for further contributions to Python projects. |
Thanks for looking at this PR so quickly, I appreciate it! I am trying to, and so far failing, to sign the CLA 😢 I submitted everything it asked for, but apparently, it takes at least one day to be processed? In the meantime, I'm just stuck waiting. Signing the CLA was a massively frustrating as an onboarding experience. I wrote a thread with the details on Twitter, if you or anyone else with the power to change things are interested in polishing it up a bit: https://twitter.com/PredragGruevski/status/1478782546624360453 |
That sounds frustrating, and I hope the PSF can improve the contributor experience in the future. On the bright side, as soon as you are approved (I think this requires a human to look at the signed form), there shouldn't be any hassle for future PRs in any PSF project. |
There's a thread on discuss.python.org at the moment talking about how to improve the process — that's where to send thoughts on the system as it is currently 🙂 https://discuss.python.org/t/faster-cla-signing-process/12722 |
Thanks, I'm glad to see folks are already considering solutions. I unfortunately feel that I've already exhausted the amount of energy I can dedicate to this. Everyone should feel free to take my suggestions from the Twitter thread (CLA link in profile details on bugs.python.org, reminder about processing delay in the "check CLA status" page, etc.) and bring them up in that discussion. |
Thank you! |
Per the Python docs and PEPs,
TypeAlias
appears to have been defined in PEP 613, not PEP 610.https://docs.python.org/3/library/typing.html#relevant-peps
https://www.python.org/dev/peps/pep-0613/
PEP 610 is titled "Recording the Direct URL Origin of installed distributions" and does not appear related to
TypeAlias
.