add dataclass_transform #1054
Merged
add dataclass_transform #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
approved these changes
Feb 2, 2022
debonte
reviewed
Feb 2, 2022
|
|
||
| """ | ||
| def decorator(cls_or_fn): | ||
| cls_or_fn.__dataclass_transform__ = { |
There was a problem hiding this comment.
Do we need to use this pattern used in final?
try:
f.__final__ = True
except (AttributeError, TypeError):
# Skip the attribute silently if it is not writable.
# AttributeError happens if the object has __slots__ or a
# read-only property, TypeError if it's a builtin class.
pass
return fThere was a problem hiding this comment.
I was more careful there because we added the behavior later after the decorator was already in the wild, and I didn't want to accidentally break something. Here, we're adding a new decorator, so I think it makes sense to start with the simpler behavior and adjust it only if there's an actual need.
Co-authored-by: Erik De Bonte <erikd@microsoft.com>
debonte
approved these changes
Feb 2, 2022
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Apr 23, 2022
Copied from typing-extensions (python/typing#1054, python/typing#1120). Documentation is intentionally omitted, so we can focus on getting the runtime part in before the feature freeze.
JelleZijlstra
added a commit
to python/cpython
that referenced
this pull request
Apr 26, 2022
Copied from typing-extensions (python/typing#1054, python/typing#1120). Documentation is intentionally omitted, so we can focus on getting the runtime part in before the feature freeze.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PEP 681.
cc @erictraut @debonte