Updated spec and conformance test to reflect that a type variable tha… #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is defined as covariant or contravariant should not generate an error when bound to a generic function or type alias. Variance has no meaning in this context, so it should be ignored. This brings the spec in alignment with the behavior of the major type checkers.
Closed
5 tasks
|
Linking python/typing-council#8 |
|
@erictraut should this have been merged before python/typing-council#8 got resolved? |
|
Oops, I mixed up this PR with another one. I didn't mean to merge this one yet. I'll revert it. |
|
Note to self: Use the "Draft" feature so it's obvious that a PR isn't yet ready to merge. |
erictraut
added a commit
to erictraut/typing
that referenced
this pull request
Jan 15, 2024
… hasn't bottomed out on the discussion.
erictraut
added a commit
that referenced
this pull request
Jan 15, 2024
|
Thanks! :-) I added some labels so hopefully we confuse ourselves less in the future |
hauntsaninja
pushed a commit
to hauntsaninja/typing
that referenced
this pull request
Jan 16, 2024
python#1576) * Updated spec and conformance test to reflect that a type variable that is defined as covariant or contravariant should not generate an error when bound to a generic function or type alias. Variance has no meaning in this context, so it should be ignored. This brings the spec in alignment with the behavior of the major type checkers. * Added comment as per PR suggestion. * Reran tests. * Fixed a botched merge that undid a previous PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t is defined as covariant or contravariant should not generate an error when bound to a generic function or type alias. Variance has no meaning in this context, so it should be ignored. This brings the spec in alignment with the behavior of the major type checkers.