Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance tests: Add mechanism for marking that an error should appear on one of several lines #1683

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conformance tests: Add mechanism for marking that an error should appear on one of several lines #1683

merged 1 commit into from
Apr 6, 2024

Conversation

JelleZijlstra
Copy link
Member

Fixes #1680

erictraut
erictraut approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@erictraut erictraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works quite well. Thanks!

@JelleZijlstra JelleZijlstra merged commit 1466b3b into python:main Apr 6, 2024
4 checks passed
@JelleZijlstra JelleZijlstra deleted the oneof branch April 6, 2024 11:38
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 6, 2024
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictraut erictraut erictraut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance tests: Add mechanism to allow errors on one of multiple lines
2 participants
@JelleZijlstra @erictraut