Pull request to merge with master #1
Conversation
| ## Testing | ||
| To run the tests for the app, and see the coverage, run | ||
| ``` | ||
| nosetests --with-coverage |
There was a problem hiding this comment.
This shows coverage even for your test dependencies. Report coverage only for your app.
There was a problem hiding this comment.
You can add a .coveragerc file to tell it what to ignore.
config/config.py
Outdated
| DEBUG = True | ||
| TESTING = False | ||
| CSRF_ENABLED = True | ||
| SECRET_KEY = 'ssssssssssssssssssssuuuuuuuuuuuuuuuuuuutttttttttttttttffffff666668778999' |
There was a problem hiding this comment.
Add the SECRET_KEY to your environment and import it from os.env
| Mako==1.0.6 | ||
| MarkupSafe==0.23 | ||
| nose==1.3.7 | ||
| passlib==1.7.0 |
There was a problem hiding this comment.
passlib and Werkzeug do the same thing... from werkzeug.security import generate_password_hash, check_password_hash It would be better to just use Werkzeug as it comes with a Flask installation.
There was a problem hiding this comment.
I used it at the start but it was returning count error , when trying to get the hashed password. any help on this
|
Changes Unknown when pulling 7b6be18 on develop into ** on master**. |
|
Changes Unknown when pulling 7677ade on develop into ** on master**. |
|
Changes Unknown when pulling a2541ca on develop into ** on master**. |
|
Changes Unknown when pulling 46ff030 on develop into ** on master**. |
|
Changes Unknown when pulling 01ee03f on develop into ** on master**. |
|
Changes Unknown when pulling d1b71e2 on develop into ** on master**. |
app/views.py
Outdated
| from flask_sqlalchemy import SQLAlchemy | ||
| from app import app, api, db | ||
| from .models import User, BucketList, BucketListItems | ||
| from .serializers import bucketlist_serializer, bucketlistitem_serializer |
There was a problem hiding this comment.
let us find a way to import without the .
config/config.py
Outdated
|
|
||
| class DevelopmentConfig(Config): | ||
| DEVELOPMENT = True | ||
| DEBUG = True |
There was a problem hiding this comment.
you are repeating yourself here since this is already L6
|
Changes Unknown when pulling 706a7e6 on develop into ** on master**. |
No description provided.