Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temp fix for unit test failure #1895

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Sep 11, 2023

This fixes the the build warnings for the following PRs, as well as future ones:

They should otherwise be ready for merge and review.

I'll get a better fix together in the coming days, [as mentioned / previewed on Discord] to include:

  1. An explanation of why the tests exist (tl;dr speedbump to make sure people update doc + follow rules)
  2. Some rudimentary typo detection
  3. Quantity checks for specific patterns

@einarf einarf merged commit cf9f2e5 into pythonarcade:development Sep 11, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants