Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled 1.9 compatibility #57

Closed
bunny-therapist opened this issue Aug 2, 2022 · 3 comments
Closed

Tiled 1.9 compatibility #57

bunny-therapist opened this issue Aug 2, 2022 · 3 comments

Comments

@bunny-therapist
Copy link

Tiled 1.9 introduced breaking changes in the json format which makes older json files crash pytiled-parser with a KeyError.

Tiled 1.9 projects can be run in 1.8 compatibility mode, which is a functioning workaround at the moment.

@Cleptomania
Copy link
Member

Cleptomania commented Aug 2, 2022

I’ll see if I can make some time to look through everything this week and see if we can make the parser compatible with both versions.

@Cleptomania
Copy link
Member

It looks like we’ll have to check the format version and dynamically handle different tags.

I’m thinking we will likely update the attribute name in our API to match the new Tiled API, but still be able to parse in the old name

@Cleptomania
Copy link
Member

I've release version 2.1.0 of pytiled-parser which should be fully functional with both Tiled 1.8 and 1.9. There is a slight API change, mainly just that the type attribute of TiledObject and Tile classes has been renamed to class_ to stay consistent with Tiled's API. I've also updated Arcade in the development branch to this version and taken care of the API change there.

I don't have the ability to do a backport to a 2.6.X version of Arcade but I will bring that up because I think this definitely needs released in a 2.6.X version of it. As it stands Arcade 2.6 is incompatible with Tiled 1.9 maps, and Arcade 2.6 is incompatible with pytiled-parser 2.1.0.

Please note that pytiled-parser 2.1.0 does not necessarily add support for new features of 1.9, it simply makes it compatible with the formats for the existing supported featureset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants