solved issue #145: adding external link icon on the review page of the proposals with content urls #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…external link icon on the proposal review page
| @register.filter(name='has_content_urls') | ||
| def get_content_urls(proposal): | ||
| if proposal.content_urls: | ||
| url = proposal.content_urls.split() |
There was a problem hiding this comment.
The content urls may have something like TBD. In this case this will pass. Ideally it should only return all urls. Here is thread to extract all links in a paragraph https://stackoverflow.com/questions/4696418/regex-to-extract-all-urls-from-a-page.
|
Once all changes are done. We can go ahead and merge it |
|
The to_review page now shows multi external link icons for multiple content urls, also validation of urls via regex implemented. |
kracekumar
added a commit
that referenced
this pull request
Jul 17, 2015
solved issue #145: adding external link icon on the review page of the proposals with content urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: Also added redirection to the first content url if multiple urls are present in the content urls.
P.S. also fixed existing flake errors