Django Allauth added #20
Conversation
|
@deshraj We should not be added library file as 410 files. Please update pull request according. |
|
Ok sure. I will remove the unnecessary files other than the templates file. Thanks for giving me the links for reference. :) |
|
@deshraj you might need to update your source code also as i have checked base template for the project. Can you integrate django-allauth with login.html page ? |
|
ok sure I will update my source code and will integrate django-allauth with login.html page. Let me know if anything else needs to be taken care of. |
|
@vnbang2003 , Are we going to use only the simple authentication using emailid only ? I can see the new commits containing old login technique added. |
|
we will use django -allauth . Just for Dev sprint purpose i made this simple login work. |
|
Oh great. I am also attending the PyCon confrences tomorrow. Lets see if I can meet you there. :) |
| @@ -38,6 +38,9 @@ | |||
| 'django.contrib.sessions', | |||
| 'django.contrib.messages', | |||
| 'django.contrib.staticfiles', | |||
| 'django.contrib.sites', | |||
| 'allauth', | |||
| 'allauth.account', | |||
There was a problem hiding this comment.
You can add this to THIRD_PARTY_APPS section.
|
Overall looks good. It seems you got some merge conflict, it would be great if you can rebase your branch against the latest code in this repository's |
|
@deshraj Can you please udpate the pull request with latest code branch. |
|
@vnbang2003 Sorry for the delay. Just updating the code. :) |
|
@vnbang2003 I have updated the PR. Please have a look and merge it if it seems fine. Do let me know if there is something to change. |
| @@ -8,21 +8,17 @@ | |||
| from wye.profiles.views import login, logout, registration, ProfileView | |||
|
|
|||
| urlpatterns = [ | |||
| url(r'^django-admin/', include(admin.site.urls)), | |||
|
|
|||
| url(r'', include('allauth.urls')), | |||
There was a problem hiding this comment.
Let make /account/ as url ?
Django allauth is added to the project. Now, only the default templates provided by django allauth are to be changed.