Use int32_t for kThreadGroupSize in cta_per_row #1338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-stroopwafel-199537 canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D39637900 |
Differential Revision: D39590263 fbshipit-source-id: e69da30cb5f89d70a796a076f0d80100233fc100
Summary: Pull Request resolved: pytorch#1338 Use int32_t for kThreadGroupSize instead of size_t in TBE bwd warp_per_row. Using size_t causes a slowdown in some cases. Differential Revision: D39637900 fbshipit-source-id: 3896c988aef660953629fde1b4feadf2247009ca
sryap
force-pushed
the
export-D39637900
branch
from
cd0d2b6
to
220c79f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39637900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use int32_t for kThreadGroupSize instead of size_t in TBE bwd
warp_per_row. Using size_t causes a slowdown in some cases.
Differential Revision: D39637900