Re-organize the backward split code generation #1871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Move the determination of `kMaxVecsPerThread` and `kThreadGroupSize` in `embedding_backward_split_template.cu` into its own macro - Update `embedding_backward_split_template.cu` to hardcode values for kMaxVecsPerThread and kThreadGroupSize for the experimental optimizers case Reviewed By: sryap Differential Revision: D47354614 fbshipit-source-id: d12c1b7a8cd0efe61f553a5101c89f2d407abef1
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D47354614 |
|
This pull request has been merged in eea19e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move the determination of
kMaxVecsPerThreadandkThreadGroupSizeinembedding_backward_split_template.cuinto its own macroUpdate
embedding_backward_split_template.cuto hardcode values for kMaxVecsPerThread and kThreadGroupSize for the experimental optimizers caseReviewed By: sryap
Differential Revision: D47354614