New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable VBE support on CPU #3174

Closed

spcyppt wants to merge 2 commits into pytorch:main from spcyppt:export-D63410944

Contributor

spcyppt commented Sep 25, 2024

Summary:
Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}embedding_codegen_lookup{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (do vbe here) -> cpu kernel). the call is done

Differential Revision: D63410944

facebook-github-bot added the cla signed label

netlify bot commented Sep 25, 2024 •

edited

Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name	Link
🔨 Latest commit	`4b88735`
🔍 Latest deploy log	https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66fc4baaaa2901000864d4e7
😎 Deploy Preview	https://deploy-preview-3174--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

4fd9e29

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from 555d40f to 4fd9e29 Compare

September 25, 2024 23:16

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

931fe2f

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from 4fd9e29 to 931fe2f Compare

September 25, 2024 23:21

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

1 similar comment

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

a60eb2e

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from 931fe2f to a60eb2e Compare

September 25, 2024 23:27

Contributor

facebook-github-bot commented Sep 26, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

c56c9b4

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from a60eb2e to c56c9b4 Compare

September 26, 2024 00:37

Contributor

facebook-github-bot commented Sep 26, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from c56c9b4 to 2b74f69 Compare

September 26, 2024 18:05

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

2b74f69

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Differential Revision: D63410944

Contributor

facebook-github-bot commented Sep 26, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

79cc1d8

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from 2b74f69 to 79cc1d8 Compare

September 26, 2024 18:11

Contributor

facebook-github-bot commented Sep 26, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

b16c1e6

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from 79cc1d8 to b16c1e6 Compare

September 26, 2024 18:22

Contributor

facebook-github-bot commented Sep 27, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

2be8b61

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Reviewed By: q10

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from b16c1e6 to 2be8b61 Compare

September 27, 2024 00:53

Contributor

facebook-github-bot commented Sep 27, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

8c4f8f5

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Reviewed By: q10

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch 2 times, most recently from 8c4f8f5 to b2c45b5 Compare

September 27, 2024 22:49

Contributor

facebook-github-bot commented Sep 27, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from b2c45b5 to a508722 Compare

September 28, 2024 06:50

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

a508722

Summary:
Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Reviewed By: q10

Differential Revision: D63410944

Contributor

facebook-github-bot commented Sep 28, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

1 similar comment

Contributor

facebook-github-bot commented Sep 30, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from a508722 to 73b8cac Compare

September 30, 2024 23:04

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

73b8cac

Summary:
X-link: facebookresearch/FBGEMM#286

Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Reviewed By: q10

Differential Revision: D63410944


          Add split_embeddings_utils_cpu

925d514

Differential Revision: D63711688

Contributor

facebook-github-bot commented Oct 1, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request


          Enable VBE support on CPU (pytorch#3174)

f2776d0

Summary:
X-link: facebookresearch/FBGEMM#286

Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Reviewed By: q10

Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from 73b8cac to f2776d0 Compare

October 1, 2024 19:17


          Enable VBE support on CPU (pytorch#3174)

4b88735

Summary:
X-link: facebookresearch/FBGEMM#286

Pull Request resolved: pytorch#3174

Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.

To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2.

This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel).  the call is done

Reviewed By: q10

Differential Revision: D63410944

Contributor

facebook-github-bot commented Oct 1, 2024

This pull request was exported from Phabricator. Differential Revision: D63410944

spcyppt force-pushed the export-D63410944 branch from f2776d0 to 4b88735 Compare

October 1, 2024 19:21

facebook-github-bot closed this in

f9de209

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Oct 1, 2024

This pull request has been merged in f9de209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported Merged