Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dtensor] changes required before moving to core #614

Merged
merged 3 commits into from
Nov 16, 2022
Merged

[dtensor] changes required before moving to core #614

merged 3 commits into from
Nov 16, 2022

Conversation

wanchaol
Copy link
Contributor

new PR replacing #587

@wanchaol wanchaol requested a review from fduwjj November 16, 2022 01:22
aazzolini
aazzolini approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@aazzolini aazzolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@wanchaol wanchaol merged commit 3e2ee5f into main Nov 16, 2022
@wanchaol wanchaol mentioned this pull request Nov 16, 2022
Closed
16 tasks
@wanchaol wanchaol deleted the to_core branch November 17, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aazzolini aazzolini aazzolini approved these changes

@awgu awgu Awaiting requested review from awgu

@mrshenli mrshenli Awaiting requested review from mrshenli

@fduwjj fduwjj Awaiting requested review from fduwjj

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanchaol @aazzolini @facebook-github-bot