Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference examples #645

Merged
merged 44 commits into from
Dec 13, 2022
Merged

Inference examples #645

merged 44 commits into from
Dec 13, 2022

Conversation

HamidShojanazeri
Copy link
Contributor

WIP to make a official example and recipe for distributed inference with pippy.

Goals

  • To make a recipe for distributed inference
  • Identify areas to simplify and improve

Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing user guide and demo!
Thanks so much for supporting PiPPy!

examples/inference/README.md Outdated Show resolved Hide resolved
examples/inference/README.md Outdated Show resolved Hide resolved
examples/inference/README.md Outdated Show resolved Hide resolved
examples/inference/t5_inference.py Outdated Show resolved Hide resolved
examples/inference/t5_inference.py Outdated Show resolved Hide resolved
print(torch.cuda.list_gpu_processes(5))
print(torch.cuda.list_gpu_processes(6))
print(torch.cuda.list_gpu_processes(7))
print("***********************************************")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not very important, let's clean these lines out.

examples/inference/t5_inference.py Outdated Show resolved Hide resolved
examples/inference/t5_inference.py Outdated Show resolved Hide resolved
examples/inference/t5_inference.py Outdated Show resolved Hide resolved
PROFILING_ENABLED = True
CHECK_NUMERIC_EQUIVALENCE = True
gigabyte_size = 1073741824
megabyte_size = 1048576
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the megabyte_size is smaller than the gigabyte_size?

Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using split_utils.py in this example anymore. We may just remove it (also because it only works for T5).

examples/inference/README.md Outdated Show resolved Hide resolved
examples/inference/README.md Outdated Show resolved Hide resolved
examples/inference/README.md Outdated Show resolved Hide resolved
@HamidShojanazeri HamidShojanazeri changed the title [WIP] Inference examples Inference examples Dec 13, 2022
@HamidShojanazeri HamidShojanazeri marked this pull request as ready for review December 13, 2022 06:11
@HamidShojanazeri HamidShojanazeri merged commit 38bee38 into main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants