Refactor tiktoken import bare except
#1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't suppress the import error if tiktoken is not installed Instead of importing it at the top of the file, we can import it inside the only functions that use these imports; we can consider a different import structure if we end up needing to access these modules in more places This lazy importing should also decrease the load time of these modules Also do the same thing for sentencepiece
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1024
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a1e9b2c with merge base c187f87 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
previously approved these changes
Oct 7, 2024
msaroufim
reviewed
Oct 7, 2024
msaroufim
approved these changes
Oct 7, 2024
jainapurva
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Refactor tiktoken import bare except We shouldn't suppress the import error if tiktoken is not installed Instead of importing it at the top of the file, we can import it inside the only functions that use these imports; we can consider a different import structure if we end up needing to access these modules in more places This lazy importing should also decrease the load time of these modules Also do the same thing for sentencepiece * Remove __future__.annotations import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't suppress the import error if
tiktokenis not installed. Also do the same thing forsentencepiece.Instead of importing them at the top of the file, we can import them inside the only functions that use them; we can consider a different import structure if we end up needing to access them elsewhere.
This lazy importing should also decrease the load time of these modules.
cc: @msaroufim