Rename Layout -> TensorImpl #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1028
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 Cancelled JobsAs of commit d1cf953 with merge base 92dd5f5 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jainapurva
added a commit
that referenced
this pull request
Oct 7, 2024
ghstack-source-id: 55059fd9ff31501faac21ffc1d1acc64cd25d99a Pull Request resolved: #1028
facebook-github-bot
added
the
CLA Signed
jerryzh168
reviewed
Oct 7, 2024
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 523a77269efd077c31469a90d6bf6d13ac7fc46d Pull Request resolved: #1028
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 523a77269efd077c31469a90d6bf6d13ac7fc46d Pull Request resolved: #1028
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: bfb9cd9f35a126985fd361722a05126c1ba1cac3 Pull Request resolved: #1028
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 49d15dc96d7398a24a1adddc4edd1339b6573e15 Pull Request resolved: #1028
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 496c76e8f0a73468759f97bf9f000baafe310849 Pull Request resolved: #1028
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 006a995d246c5723044bce4f766aa6c8b17f3b26 Pull Request resolved: #1028
jerryzh168
reviewed
Oct 8, 2024
jerryzh168
reviewed
Oct 8, 2024
jerryzh168
reviewed
Oct 8, 2024
jerryzh168
reviewed
Oct 8, 2024
jerryzh168
reviewed
Oct 8, 2024
jerryzh168
reviewed
Oct 8, 2024
jerryzh168
reviewed
Oct 8, 2024
Co-authored-by: Jerry Zhang <jerryzh168@gmail.com>
jainapurva
changed the base branch from
gh/jainapurva/1/orig
to
gh/jainapurva/1/base
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 4b70c6d9e738f033abc28421c85e3ed3023e3220 Pull Request resolved: #1028
|
This PR doesn't have a description so it's kind of difficult to know what the intent was here. Was Layout incorrect terminology? Is TensorImpl clearer? What does TensorImpl intend to say? |
msaroufim
added a commit
that referenced
this pull request
Oct 8, 2024
jainapurva
added a commit
that referenced
this pull request
Oct 9, 2024
jainapurva
pushed a commit
that referenced
this pull request
Oct 9, 2024
jainapurva
added a commit
that referenced
this pull request
Oct 9, 2024
jainapurva
added a commit
that referenced
this pull request
Oct 15, 2024
jainapurva
pushed a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Renaming to improve AQT readability. AQT Layout is similar to “TensorImpl” (following the naming for https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/SparseTensorImpl.h)