Change torchao quantization types from int to size_t and preface vars with "preferred_" #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1041
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63873383 |
keyan
force-pushed
the
export-D63873383
branch
from
231ae6e
to
6e03e7d
Compare
keyan
added a commit
to keyan/ao
that referenced
this pull request
Oct 9, 2024
… with "preferred_" (pytorch#1041) Summary: 1. Change the types of activation_data_alignment and weight_data_alignment from int to size_t. 2. Change the return types of activation_data_size_fn_type and weight_data_size_fn_type from int to size_t. 3. Rename activation_data_alignment to preferred_activation_data_alignment. 4. Rename weight_data_alignment to preferred_weight_data_alignment Differential Revision: D63873383
|
This pull request was exported from Phabricator. Differential Revision: D63873383 |
metascroy
reviewed
Oct 9, 2024
...aarch64/linear/channelwise_8bit_activation_groupwise_lowbit_weight_1x8x16_f32_neondot-impl.h
Show resolved
Hide resolved
metascroy
reviewed
Oct 9, 2024
metascroy
reviewed
Oct 9, 2024
torchao/experimental/ops/linear_8bit_act_xbit_weight/linear_8bit_act_xbit_weight.cpp
Show resolved
Hide resolved
metascroy
reviewed
Oct 9, 2024
torchao/experimental/ops/linear_8bit_act_xbit_weight/linear_8bit_act_xbit_weight.h
Outdated
Show resolved
Hide resolved
metascroy
reviewed
Oct 9, 2024
torchao/experimental/ops/linear_8bit_act_xbit_weight/linear_8bit_act_xbit_weight.h
Outdated
Show resolved
Hide resolved
metascroy
reviewed
Oct 9, 2024
torchao/experimental/ops/linear_8bit_act_xbit_weight/op_linear_8bit_act_xbit_weight-impl.h
Outdated
Show resolved
Hide resolved
metascroy
reviewed
Oct 9, 2024
torchao/experimental/ops/linear_8bit_act_xbit_weight/op_linear_8bit_act_xbit_weight-impl.h
Outdated
Show resolved
Hide resolved
… with "preferred_" (pytorch#1041) Summary: 1. Change the types of activation_data_alignment and weight_data_alignment from int to size_t. 2. Change the return types of activation_data_size_fn_type and weight_data_size_fn_type from int to size_t. 3. Rename activation_data_alignment to preferred_activation_data_alignment. 4. Rename weight_data_alignment to preferred_weight_data_alignment Differential Revision: D63873383
keyan
force-pushed
the
export-D63873383
branch
from
6e03e7d
to
84597da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63873383 |
|
Ready for another look @metascroy, thanks! |
Changes look good! Did you rerun the tests after making them? |
Yes, everything compiled/passed when running: |
metascroy
approved these changes
Oct 10, 2024
jainapurva
pushed a commit
that referenced
this pull request
Oct 15, 2024
… with "preferred_" Differential Revision: D63873383 Pull Request resolved: #1041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D63873383