smoothquant fixes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: certain custom linear modules add additional inputs to the forward that need to be handled but can be otherwise ignored. Test Plan: python test/test.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 20, 2023
Summary: certain custom linear modules add additional inputs to the forward that need to be handled but can be otherwise ignored. Test Plan: python test/test.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8c544ee2f50531f852d86a862acf93b7113cd4ce Pull Request resolved: #28
facebook-github-bot
added
the
CLA Signed
HDCharles
changed the title
Summary: certain custom linear modules add additional inputs to the forward that need to be handled but can be otherwise ignored. Additionally swap_linear_with_smooth_fq_linear had a bug where linear subclasses would get past the if statement and error on the dict key lookup since the actual class wasn't expected. (#30) enabled NonDynamicallyQuantizableLinear to work with smoothquant and fixed bug for other subclasses. At some point this should be brought in line with the other APIs if its getting use. Test Plan: python test/test.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Jan 3, 2024
Summary: certain custom linear modules add additional inputs to the forward that need to be handled but can be otherwise ignored. Additionally swap_linear_with_smooth_fq_linear had a bug where linear subclasses would get past the if statement and error on the dict key lookup since the actual class wasn't expected. (#30) enabled NonDynamicallyQuantizableLinear to work with smoothquant and fixed bug for other subclasses. At some point this should be brought in line with the other APIs if its getting use. Test Plan: python test/test.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 059b392376f36bf13be16ec992a52063707b5abc Pull Request resolved: #28
HDCharles
added a commit
that referenced
this pull request
Jan 3, 2024
Summary: certain custom linear modules add additional inputs to the forward that need to be handled but can be otherwise ignored. Additionally swap_linear_with_smooth_fq_linear had a bug where linear subclasses would get past the if statement and error on the dict key lookup since the actual class wasn't expected. (#30) enabled NonDynamicallyQuantizableLinear to work with smoothquant and fixed bug for other subclasses. At some point this should be brought in line with the other APIs if its getting use. Test Plan: python test/test.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 059b392376f36bf13be16ec992a52063707b5abc Pull Request resolved: #28
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: certain custom linear modules add additional inputs to the forward that need to be handled but can be otherwise ignored. Additionally swap_linear_with_smooth_fq_linear had a bug where linear subclasses would get past the if statement and error on the dict key lookup since the actual class wasn't expected. (pytorch#30) enabled NonDynamicallyQuantizableLinear to work with smoothquant and fixed bug for other subclasses. At some point this should be brought in line with the other APIs if its getting use. Test Plan: python test/test.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 059b392376f36bf13be16ec992a52063707b5abc Pull Request resolved: pytorch#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: certain custom linear modules add additional inputs to the
forward that need to be handled but can be otherwise ignored.
Additionally swap_linear_with_smooth_fq_linear had a bug where linear
subclasses would get past the if statement and error on the dict key
lookup since the actual class wasn't expected.
(#30) enabled
NonDynamicallyQuantizableLinear to work with smoothquant and fixed bug
for other subclasses. At some point this should be brought in line with
the other APIs if its getting use.
Test Plan: python test/test.py
Reviewers:
Subscribers:
Tasks:
Tags: