add ruff lint rule to remove unused imports via ruff

[jimexist]

• include stricter linter rules for the allowlisted files
• add more comments
• use python 11 for ruff run
• fix ruff to 0.6.8 to make it consistent

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/969

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9006929 with merge base c0a81f9 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[msaroufim]

So for linting feel free to add a new file or folder here and make all the changes you need https://github.com/pytorch/ao/blob/main/ruff.toml

It's tricky for us to merge something like this since eveyrone would need to rebase their code

[jimexist]

So for linting feel free to add a new file or folder here and make all the changes you need https://github.com/pytorch/ao/blob/main/ruff.toml

It's tricky for us to merge something like this since eveyrone would need to rebase their code

thank you for the reference. that makes sense.
i then only updated the GitHub workflow to include the new rule. this renders no difference on the list of included files in the toml config.

[msaroufim]

Ok cool! Can you remove unused imports in files erroring in CI and we can merge this

[jimexist]

Ok cool! Can you remove unused imports in files erroring in CI and we can merge this

turns out the ruff linter is configured to:

1. format w.r.t the listed files
2. apply the limited ruleset for all files

my change is to include a stricter linter rule but only applies to the allowlist, kind of between 1 and 2

[jimexist]

e999 was deprecated and by default applied

[msaroufim]

how come?

[jimexist]

Rule set changes with versions so this is to avoid sudden breakage if they release a newer version

[msaroufim]

@drisspg any preference on this?

Cause btw now locally vs remotely there'll be ruff deviations https://github.com/pytorch/ao/blob/main/dev-requirements.txt#L22

[drisspg]

That's fine; I think we just need to also pin in dev-requirments.txt

I kept it loose since it's a pretty common dependency and didn't want to thrash environments, but pinning is better practice

[jimexist]

Suggested change

	python-version: ["3.11"]
	python-version: ["3.9"]