You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
T.VAD currently treats all the tracks in the input batch as belong to the same audio data. This means that it returns different results when samples are batched and samples are fed independently.
There is a test to ensure the consistency of operation result regardless of batched/un-bached, but T.VAD in this test does not make sense. We would like to remove it.
I'll take this, but doesn't the test you quoted test JIT consistency, rather than batch consistency? (Edit: so while T.VAD remains in the codebase, it would be desirable to keep.)
See #1348 for the background
T.VAD
currently treats all the tracks in the input batch as belong to the same audio data. This means that it returns different results when samples are batched and samples are fed independently.There is a test to ensure the consistency of operation result regardless of batched/un-bached, but
T.VAD
in this test does not make sense. We would like to remove it.audio/test/torchaudio_unittest/transforms/torchscript_consistency_impl.py
Lines 92 to 95 in 6a677ac
Steps
Testing and building
Please refer to
CONTRIBUTING.md
.The text was updated successfully, but these errors were encountered: