Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove T.VAD from transform batch consistency test #1449

Closed
mthrok opened this issue Apr 12, 2021 · 2 comments · Fixed by #1451
Closed

Remove T.VAD from transform batch consistency test #1449

mthrok opened this issue Apr 12, 2021 · 2 comments · Fixed by #1451

Comments

@mthrok
Copy link
Collaborator

mthrok commented Apr 12, 2021

See #1348 for the background

T.VAD currently treats all the tracks in the input batch as belong to the same audio data. This means that it returns different results when samples are batched and samples are fed independently.

There is a test to ensure the consistency of operation result regardless of batched/un-bached, but T.VAD in this test does not make sense. We would like to remove it.

def test_Vad(self):
filepath = common_utils.get_asset_path("vad-go-mono-32000.wav")
waveform, sample_rate = common_utils.load_wav(filepath)
self._assert_consistency(T.Vad(sample_rate=sample_rate), waveform)

Steps

  1. Remove the test

Testing and building

Please refer to CONTRIBUTING.md.

@jcaw
Copy link
Contributor

jcaw commented Apr 13, 2021

I'll take this, but doesn't the test you quoted test JIT consistency, rather than batch consistency? (Edit: so while T.VAD remains in the codebase, it would be desirable to keep.)

@mthrok
Copy link
Collaborator Author

mthrok commented Apr 13, 2021

Oops my bad. Yes, I meant the batch consistency test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants