Remove VAD from batch consistency tests #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VAD function trims the input tensor to the first instance of voice activity on any channel or item. Trimming batches this way may be undesirable as the item with earliest activity will dominate. Either way, the batch behaviour does not match the itemwise behaviour. The VAD batch consistency tests currently pass out of coincidence, but they specify incorrect behaviour. This commit removes them.
carolineechen
pushed a commit
to carolineechen/audio
that referenced
this pull request
Apr 30, 2021
The VAD function trims the input tensor to the first instance of voice activity on any channel or item. Trimming batches this way may be undesirable as the item with earliest activity will dominate. Either way, the batch behaviour does not match the itemwise behaviour. The VAD batch consistency tests currently pass out of coincidence, but they specify incorrect behaviour. This commit removes them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1348 and #1449, the VAD function trims the input tensor to the first instance of voice activity on any channel or item. Trimming batches this way may be undesirable as the item with earliest activity will dominate, but either way, the batch behaviour does not match the itemwise behaviour.
The functional VAD batch consistency tests currently pass out of coincidence, but they specify incorrect behaviour. This PR removes these tests.
Closes #1449