Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVFuser userbenchmarks - use JSON output format #920

Closed

Conversation

davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented May 19, 2022

Stack from ghstack:

Ran python run_benchmark.py nvfuser --filter autogen-4.

There's some stdout, plus the following output that was dumped into .userbenchmark/nvfuser/metrics-20220519221324.json:

{
    "name": "nvfuser",
    "environ": {
        "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1"
    },
    "metrics": {
        "no_fuser:autogen-4": 0.360220073023811,
        "nnc-static:autogen-4": 0.34597328188829124,
        "nnc-dynamic:autogen-4": 0.3488327481318265,
        "nvfuser:autogen-4": 0.4082540248055011
    }
}

Differential Revision: D36553164

Ran `python run_benchmark.py nvfuser --filter autogen-4`.

There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`:

```json
{
    "name": "nvfuser",
    "environ": {
        "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1"
    },
    "metrics": {
        "no_fuser:autogen-4": 0.360220073023811,
        "nnc-static:autogen-4": 0.34597328188829124,
        "nnc-dynamic:autogen-4": 0.3488327481318265,
        "nvfuser:autogen-4": 0.4082540248055011
    }
}
```

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request May 19, 2022
Ran `python run_benchmark.py nvfuser --filter autogen-4`.

There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`:

```json
{
    "name": "nvfuser",
    "environ": {
        "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1"
    },
    "metrics": {
        "no_fuser:autogen-4": 0.360220073023811,
        "nnc-static:autogen-4": 0.34597328188829124,
        "nnc-dynamic:autogen-4": 0.3488327481318265,
        "nvfuser:autogen-4": 0.4082540248055011
    }
}
```

ghstack-source-id: a3fd0d7df09e565acb7517056d2ef10dd8055b4f
Pull Request resolved: #920
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/6/head branch May 24, 2022 14:16
gairgeio added a commit to gairgeio/benchmark that referenced this pull request Aug 2, 2024
Summary:
Pull Request resolved: pytorch/benchmark#920

Ran `python run_benchmark.py nvfuser --filter autogen-4`.

There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`:

```json
{
    "name": "nvfuser",
    "environ": {
        "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1"
    },
    "metrics": {
        "no_fuser:autogen-4": 0.360220073023811,
        "nnc-static:autogen-4": 0.34597328188829124,
        "nnc-dynamic:autogen-4": 0.3488327481318265,
        "nvfuser:autogen-4": 0.4082540248055011
    }
}
```

Test Plan: Imported from OSS

Reviewed By: eellison, xuzhao9

Differential Revision: D36553164

Pulled By: davidberard98

fbshipit-source-id: 5487be82e1466b50a3bd102c5fe54bb000334900
bestappsandcodereviews7 added a commit to bestappsandcodereviews7/benchmark that referenced this pull request Aug 16, 2024
Summary:
Pull Request resolved: pytorch/benchmark#920

Ran `python run_benchmark.py nvfuser --filter autogen-4`.

There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`:

```json
{
    "name": "nvfuser",
    "environ": {
        "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1"
    },
    "metrics": {
        "no_fuser:autogen-4": 0.360220073023811,
        "nnc-static:autogen-4": 0.34597328188829124,
        "nnc-dynamic:autogen-4": 0.3488327481318265,
        "nvfuser:autogen-4": 0.4082540248055011
    }
}
```

Test Plan: Imported from OSS

Reviewed By: eellison, xuzhao9

Differential Revision: D36553164

Pulled By: davidberard98

fbshipit-source-id: 5487be82e1466b50a3bd102c5fe54bb000334900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants