-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVFuser userbenchmarks - use JSON output format #920
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran `python run_benchmark.py nvfuser --filter autogen-4`. There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`: ```json { "name": "nvfuser", "environ": { "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1" }, "metrics": { "no_fuser:autogen-4": 0.360220073023811, "nnc-static:autogen-4": 0.34597328188829124, "nnc-dynamic:autogen-4": 0.3488327481318265, "nvfuser:autogen-4": 0.4082540248055011 } } ``` [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
May 19, 2022
Ran `python run_benchmark.py nvfuser --filter autogen-4`. There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`: ```json { "name": "nvfuser", "environ": { "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1" }, "metrics": { "no_fuser:autogen-4": 0.360220073023811, "nnc-static:autogen-4": 0.34597328188829124, "nnc-dynamic:autogen-4": 0.3488327481318265, "nvfuser:autogen-4": 0.4082540248055011 } } ``` ghstack-source-id: a3fd0d7df09e565acb7517056d2ef10dd8055b4f Pull Request resolved: #920
xuzhao9
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
eellison
approved these changes
May 20, 2022
5 tasks
gairgeio
added a commit
to gairgeio/benchmark
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: pytorch/benchmark#920 Ran `python run_benchmark.py nvfuser --filter autogen-4`. There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`: ```json { "name": "nvfuser", "environ": { "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1" }, "metrics": { "no_fuser:autogen-4": 0.360220073023811, "nnc-static:autogen-4": 0.34597328188829124, "nnc-dynamic:autogen-4": 0.3488327481318265, "nvfuser:autogen-4": 0.4082540248055011 } } ``` Test Plan: Imported from OSS Reviewed By: eellison, xuzhao9 Differential Revision: D36553164 Pulled By: davidberard98 fbshipit-source-id: 5487be82e1466b50a3bd102c5fe54bb000334900
bestappsandcodereviews7
added a commit
to bestappsandcodereviews7/benchmark
that referenced
this pull request
Aug 16, 2024
Summary: Pull Request resolved: pytorch/benchmark#920 Ran `python run_benchmark.py nvfuser --filter autogen-4`. There's some stdout, plus the following output that was dumped into `.userbenchmark/nvfuser/metrics-20220519221324.json`: ```json { "name": "nvfuser", "environ": { "pytorch_git_version": "fdd5462cd93af8a835e5e5616d6c85c7553b9be1" }, "metrics": { "no_fuser:autogen-4": 0.360220073023811, "nnc-static:autogen-4": 0.34597328188829124, "nnc-dynamic:autogen-4": 0.3488327481318265, "nvfuser:autogen-4": 0.4082540248055011 } } ``` Test Plan: Imported from OSS Reviewed By: eellison, xuzhao9 Differential Revision: D36553164 Pulled By: davidberard98 fbshipit-source-id: 5487be82e1466b50a3bd102c5fe54bb000334900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Ran
python run_benchmark.py nvfuser --filter autogen-4
.There's some stdout, plus the following output that was dumped into
.userbenchmark/nvfuser/metrics-20220519221324.json
:Differential Revision: D36553164