Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add num_outputs property to the model API #295

Closed
Balandat opened this issue Oct 17, 2019 · 1 comment
Closed

Add num_outputs property to the model API #295

Balandat opened this issue Oct 17, 2019 · 1 comment
Assignees
@Balandat
Labels
enhancement New feature or request

Comments

@Balandat
Copy link
Contributor

Currently only BatchedMuliOutputGpyTorchModels have a _num_outputs property for internal bookkeeping. It would be good to have a num_outputs property defined for all models, so this can be used in a transparent fashion, e.g. for making sure that we don't use multi-output models with acquisition functions that do not support them.

I'm hesitant to add more and more sugar to the required model API so as to not make it super hard to implement custom models, but this change seems to be lightweight enough. We can also not make it an abstract property, but just raise a NotImplementedError, so people who don't need it don't need to worry about it.
This was referenced Nov 27, 2019
Closed
Closed
@Balandat Balandat self-assigned this Nov 27, 2019
@Balandat Balandat added the enhancement New feature or request label Nov 27, 2019
Balandat added a commit to Balandat/botorch that referenced this issue Nov 28, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API
04cefa0 
Summary: Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: 92ffb76ff4708a3811e08222c7d93dc4ec3bcc87
@Balandat Balandat mentioned this issue Nov 28, 2019
Closed
Balandat added a commit to Balandat/botorch that referenced this issue Nov 28, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API
455fef7 
Summary: Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: e1c85ddfd2243aa637b80e846309cd54a68b98f4
Balandat added a commit to Balandat/botorch that referenced this issue Nov 28, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API
30aa541 
Summary: Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: 54c684624b143b8b68342d08510b8fdb578c37e5
Balandat added a commit to Balandat/botorch that referenced this issue Nov 28, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API
26e2df9 
Summary: Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: 97394411c40fdafeae89ea819c8dad2b901f571f
Balandat added a commit to Balandat/botorch that referenced this issue Dec 2, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API
e4ca943 
Summary: Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: 26073074f2157f052fc19cfe7780ffd54978401b
Balandat added a commit to Balandat/botorch that referenced this issue Dec 2, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API
712bab6 
Summary: Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: 0c026b2843f161baa4016a2a4d14a28b19b24f77
Balandat added a commit to Balandat/botorch that referenced this issue Dec 2, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API (pytorch#330)
eb54a84 
Summary:
Pull Request resolved: pytorch#330

Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: 1c89ffb6aa63b4309564d679032b3e23c41f4b51
Balandat added a commit to Balandat/botorch that referenced this issue Dec 2, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API
1605573 
Summary: Addresses pytorch#295.

Differential Revision: D18737863

fbshipit-source-id: 20d38472798a1abde3f4b1418c3352b36e021738
Balandat added a commit to Balandat/botorch that referenced this issue Dec 2, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API (pytorch#330)
5c2b58a 
Summary:
Pull Request resolved: pytorch#330

Addresses pytorch#295.

Reviewed By: liangshi7

Differential Revision: D18737863

fbshipit-source-id: 937c2c213350b7d4381bae31013861d858a98698
facebook-github-bot pushed a commit that referenced this issue Dec 2, 2019
@Balandat @facebook-github-bot
Add num_outputs property to the Model API (#330)
84e716f 
Summary:
Pull Request resolved: #330

Addresses #295.

Reviewed By: liangshi7

Differential Revision: D18737863

fbshipit-source-id: 3df4d6b2b2b65609ac508e990d735838df33357b
@Balandat
Copy link
Contributor Author

Balandat commented Dec 4, 2019

Addressed in #330

@Balandat Balandat closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balandat Balandat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Balandat