Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for categoricals in Round input transform and use STEs #1516

Closed
wants to merge 2 commits into from

Conversation

sdaulton
Copy link
Contributor

Summary: see title

Differential Revision: D41477456

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Nov 22, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41477456

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1516 (94e7c7f) into main (92f0d1d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 94e7c7f differs from pull request most recent head 5b2f8bd. Consider uploading reports for the commit 5b2f8bd to get more accurate results

@@            Coverage Diff            @@
##              main     #1516   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          149       149           
  Lines        12904     12936   +32     
=========================================
+ Hits         12904     12936   +32     
Impacted Files Coverage Δ
botorch/test_functions/multi_objective.py 100.00% <ø> (ø)
botorch/models/transforms/input.py 100.00% <100.00%> (ø)
botorch/utils/rounding.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 22, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: D41477456

fbshipit-source-id: 7ffbe243596833c3af26ecaf9fb9fb4a8ebc0eb6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41477456

sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 22, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: D41477456

fbshipit-source-id: d2ca724f513eb07418a4ac65323be52b684c94d9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41477456

sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 22, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: https://internalfb.com/D41477456

fbshipit-source-id: d2baf6364330f8cdcb9b8505f39252f1c1d8470e
sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 22, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: https://internalfb.com/D41477456

fbshipit-source-id: c70b50e616a992df03bab0b61f1289144b4c7440
sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 23, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: https://internalfb.com/D41477456

fbshipit-source-id: dc59205ad5ca307dc3c475ed3015a6abcfd949c6
sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 23, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: https://internalfb.com/D41477456

fbshipit-source-id: 9c8a4f9f1ed292061f5f83326c72b4a93f8bd940
@sdaulton
Copy link
Contributor Author

Note: this changes the default behavior of Round to have approximate=False.

sdaulton and others added 2 commits November 23, 2022 10:03
…tion functions (pytorch#1515)

Summary:
Pull Request resolved: pytorch#1515

see title

Differential Revision: https://internalfb.com/D41475380

fbshipit-source-id: 3352acfda0af907e2cc2d6a35bb7fbd9bab70666
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Reviewed By: Balandat

Differential Revision: D41477456

fbshipit-source-id: b7bff1ff56fc48514bf323788656eb100a1ce6f2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41477456

sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 23, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: https://internalfb.com/D41477456

fbshipit-source-id: 7a9d5c6b2c18a2d393afa1ad078702e39c63ad40
sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 23, 2022
…ytorch#1516)

Summary:
Pull Request resolved: pytorch#1516

see title

Differential Revision: https://internalfb.com/D41477456

fbshipit-source-id: 64b5a4e236e08d09ab237187848c1daf47c9bdbf
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Apr 30, 2024
Summary: Deprecated since pytorch#1516

Differential Revision: D56799439
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request May 1, 2024
Summary: Deprecated since pytorch#1516

Differential Revision: D56799439
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request May 1, 2024
Summary: Deprecated since pytorch#1516

Differential Revision: D56799439
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request May 1, 2024
Summary: Deprecated since pytorch#1516

Differential Revision: D56799439
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request May 1, 2024
Summary: Deprecated since pytorch#1516

Reviewed By: Balandat

Differential Revision: D56799439
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request May 1, 2024
Summary: Deprecated since pytorch#1516

Differential Revision: D56799439
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request May 1, 2024
Summary: Deprecated since pytorch#1516

Differential Revision: D56799439
facebook-github-bot pushed a commit that referenced this pull request May 1, 2024
Summary: Deprecated since #1516

Reviewed By: Balandat

Differential Revision: D56799439

fbshipit-source-id: cfe43e55b45bbf77d6da33d8aa10b8fde91d2e44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants