Hotfix/polytopesampler seed #1968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #1968 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 178 178
Lines 15748 15748
=========================================
Hits 15748 15748
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Balandat
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During bugfixing, I came around the issue that setting a seed in
get_polytope_samplesis not leading to the same samples when called several times with the same seed. This PR fixes it.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Unit tests.