Don't allow unused keyword arguments in Model.construct_inputs #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 6, 2024
Summary: We have been testing multi-fidelity search spaces with single-fidelity models. Once pytorch/botorch#2186 lands, this will raise an exception because fidelity parameters will be passed to Botorch model input constructors that don't accept them. Differential Revision: D53444637
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 9, 2024
Summary: We have been testing multi-fidelity search spaces with single-fidelity models. Once pytorch/botorch#2186 lands, this will raise an exception because fidelity parameters will be passed to Botorch model input constructors that don't accept them. Reviewed By: SebastianAment Differential Revision: D53444637
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 9, 2024
Summary: We have been testing multi-fidelity search spaces with single-fidelity models. Once pytorch/botorch#2186 lands, this will raise an exception because fidelity parameters will be passed to Botorch model input constructors that don't accept them. Reviewed By: SebastianAment Differential Revision: D53444637
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Feb 9, 2024
Summary: Pull Request resolved: #2184 We have been testing multi-fidelity search spaces with single-fidelity models. Once pytorch/botorch#2186 lands, this will raise an exception because fidelity parameters will be passed to Botorch model input constructors that don't accept them. Reviewed By: SebastianAment Differential Revision: D53444637 fbshipit-source-id: 343e5557e1c6495022d121ef5c9488ca4eae8cb1
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 15, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
04edaf2
to
a93ae8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 15, 2024
Summary: * Don't pass the option `some_option` to the SingleTaskGP input constructor. This will trigger errors in pytorch/botorch#2186 Differential Revision: D53825351
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 22, 2024
…ok#2203) Summary: * Don't pass the option `some_option` to the SingleTaskGP input constructor. This will trigger errors in pytorch/botorch#2186 Reviewed By: sdaulton Differential Revision: D53825351
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 22, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
a93ae8b
to
b3bd1de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 22, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
b3bd1de
to
59e3d8f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Feb 22, 2024
Summary: Pull Request resolved: #2203 * Don't pass the option `some_option` to the SingleTaskGP input constructor. This will trigger errors in pytorch/botorch#2186 Reviewed By: sdaulton Differential Revision: D53825351 fbshipit-source-id: 5e727cbe39ae1d588092951e12768e278d6056c7
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 28, 2024
Summary: Prior to D53814087, `metric_names` could be be passed to `BoTorchModel.fit` as a named argument. After D53814087, if `metric_names` are passed they are absorbed into `**additional_model_inputs` and eventually ignored. Starting in D53086323 (pytorch/botorch#2186), such inputs will error rather than be ignored. Differential Revision: D54320622
esantorella
force-pushed
the
export-D53086323
branch
from
59e3d8f
to
98cac0d
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 28, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
==========================================
- Coverage 99.97% 99.87% -0.10%
==========================================
Files 197 188 -9
Lines 17165 16741 -424
==========================================
- Hits 17160 16720 -440
- Misses 5 21 +16 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 28, 2024
Summary: Prior to D53814087, `metric_names` could be be passed to `BoTorchModel.fit` as a named argument. After D53814087, if `metric_names` are passed they are absorbed into `**additional_model_inputs` and eventually ignored. Starting in D53086323 (pytorch/botorch#2186), such inputs will error rather than be ignored. Reviewed By: Balandat Differential Revision: D54320622
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 28, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
98cac0d
to
aab42e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Feb 29, 2024
Summary: Prior to D53814087, `metric_names` could be be passed to `BoTorchModel.fit` as a named argument. After D53814087, if `metric_names` are passed they are absorbed into `**additional_model_inputs` and eventually ignored. Starting in D53086323 (pytorch/botorch#2186), such inputs will error rather than be ignored. Reviewed By: Balandat Differential Revision: D54320622 fbshipit-source-id: 6afec3ab889d3493963c598eb459a2f6e5498a66
esantorella
force-pushed
the
export-D53086323
branch
from
aab42e9
to
c3aeda8
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Mar 15, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 12, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
c3aeda8
to
e0fb3fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 12, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
e0fb3fa
to
7cb895d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 17, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
7cb895d
to
46d36d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 17, 2024
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Reviewed By: saitcakmak Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
46d36d5
to
c57c8ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
…ch#2186) Summary: Pull Request resolved: pytorch#2186 Reviewed By: saitcakmak Differential Revision: D53086323
esantorella
force-pushed
the
export-D53086323
branch
from
c57c8ee
to
7f0ab2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53086323 |
|
This pull request has been merged in ee8aef0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: BoTorch changes to go with the subsequent Ax diff. This will eventually need to be landed with this diff going before the Ax diff.
Differential Revision: D53086323