Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricting mpmath <= 1.3 #2222

Closed
wants to merge 1 commit into from

Conversation

SebastianAment
Copy link
Contributor

@SebastianAment SebastianAment commented Feb 26, 2024

This commit restricts mpmath to versions <=1.3, since the latest alpha release breaks sympy -> pytorch -> gpytorch -> botorch.

See also sympy/sympy#26273 and the commit removing rational from mpmath.

Differential Revision: D54214691

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54214691

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 26, 2024
Differential Revision: D54214691
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54214691

@Balandat Balandat changed the title Restricting mpmath < 1.3 Restricting mpmath <= 1.3 Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (d213f3c) to head (84ac936).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         188      188           
  Lines       16745    16745           
=======================================
  Hits        16720    16720           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saitcakmak
Copy link
Contributor

merged

@saitcakmak saitcakmak closed this Feb 27, 2024
@nawtrey nawtrey mentioned this pull request Mar 9, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants