Fix non-None constraint noise levels in some constrained test problems #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inadvertently overridden / nnot properly set in some constructors.We don't properly test that this attribute is correctly assigned upon instantiation, we should fix this in a follow-up.
facebook-github-bot
added
the
CLA Signed
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 188 188
Lines 16744 16744
=======================================
Hits 16723 16723
Misses 21 21 ☔ View full report in Codecov by Sentry. |
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inadvertently overridden / nnot properly set in some constructors.
We currently don't properly test that this attribute is correctly assigned upon instantiation. It's not straightforward to figure out how to easily do this in the current test setup; we can figure that out in a follow-up.