Increase code-sharing of LCEMGP & define construct_inputs #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This allows creation of MTGPs that support inference from tasks that don't appear in the training data. See pytorch#2265 for some discussion on how the task covariance behaves in the absence of task specific data. Differential Revision: D53029681
Summary: Increases code sharing between LCEMGP & the parent MultiTaskGP: - Allows customizing mean, covariance & likelihood modules. - Eliminates duplicate `forward` implementation by renaming `task_covar_matrix` to `task_covar_module`. Defines a `construct_inputs` method for LCEMGP that supports the kwargs used to customize the task covariance module (which differ from those used for MultiTaskGP). Differential Revision: D55935507
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55935507 |
|
This pull request has been merged in dc219ca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Increases code sharing between LCEMGP & the parent MultiTaskGP:
forwardimplementation by renamingtask_covar_matrixtotask_covar_module.Defines a
construct_inputsmethod for LCEMGP that supports the kwargs used to customize the task covariance module (which differ from those used for MultiTaskGP).Differential Revision: D55935507