Acquisition function input constructor registry #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D28277557 |
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 105 106 +1
Lines 7209 7324 +115
========================================
+ Hits 7207 7322 +115
Misses 2 2
Continue to review full report at Codecov.
|
|
This pull request was exported from Phabricator. Differential Revision: D28277557 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 12, 2021
Summary: Pull Request resolved: pytorch#788 See pytorch#784 (reply in thread). This is currently not covering all acquisition functions, and focusing only on the ones in `analytic.py` and `monte_carlo.py`. In particular, KG and MES-ish ones are missing for now Differential Revision: D28277557 fbshipit-source-id: 972d3306abc4def03ca38cdd8032afb960038e61
Balandat
force-pushed
the
export-D28277557
branch
from
263b5d3
to
6809a58
Compare
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 16, 2021
Summary: Pull Request resolved: pytorch#788 See pytorch#784 (reply in thread). This is currently not covering all acquisition functions, and focusing only on the ones in `analytic.py` and `monte_carlo.py`. In particular, KG and MES-ish ones are missing for now Differential Revision: D28277557 fbshipit-source-id: 23267d8848c32476ca8be68f4a4b8fe43e93e355
Balandat
force-pushed
the
export-D28277557
branch
from
6809a58
to
a778465
Compare
|
This pull request was exported from Phabricator. Differential Revision: D28277557 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 16, 2021
Summary: Pull Request resolved: pytorch#788 See pytorch#784 (reply in thread). This is currently not covering all acquisition functions, and focusing only on the ones in `analytic.py` and `monte_carlo.py`. In particular, KG and MES-ish ones are missing for now Differential Revision: D28277557 fbshipit-source-id: 00c13bbbeff345b2bc0cdda506abd20c7f3ea5f4
Balandat
force-pushed
the
export-D28277557
branch
from
a778465
to
e88140b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D28277557 |
Differential Revision: D28389808 fbshipit-source-id: 5838f987986b88cd700f79532a0c13465753b3a0
Summary: Pull Request resolved: pytorch#788 See pytorch#784 (reply in thread). This is currently not covering all acquisition functions, and focusing only on the ones in `analytic.py` and `monte_carlo.py`. In particular, KG and MES-ish ones are missing for now Reviewed By: lena-kashtelyan Differential Revision: D28277557 fbshipit-source-id: 7687fd05cf4be731925e4961b841d4d8324e9ead
Balandat
force-pushed
the
export-D28277557
branch
from
e88140b
to
96fdd40
Compare
|
This pull request was exported from Phabricator. Differential Revision: D28277557 |
|
This pull request has been merged in d6393d5. |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 22, 2021
Summary: Add additional constructors that were not part of D28277557 (pytorch@d6393d5) / pytorch#788. Punting on `ConstrainedExpectedImprovement` for now. Differential Revision: D28454735 fbshipit-source-id: 16e18b5ad5fa3065b558bc8f982278828f95fb57
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 22, 2021
Summary: Pull Request resolved: pytorch#802 Add additional constructors that were not part of D28277557 (pytorch@d6393d5) / pytorch#788. Punting on `ConstrainedExpectedImprovement` for now. Reviewed By: lena-kashtelyan Differential Revision: D28454735 fbshipit-source-id: 1488f6a328e7353c6d427ccd7bdca9db36ba9697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See #784 (reply in thread).
This is currently not covering all acquisition functions, and focusing only on the ones in
analytic.pyandmonte_carlo.py. In particular, KG and MES-ish ones are missing for nowDifferential Revision: D28277557