Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows cuda 11.6 changes #999

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Windows cuda 11.6 changes #999

merged 1 commit into from
Mar 23, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Mar 21, 2022 •
edited

Windows cuda 11.6 changes

@atalman atalman changed the title Testing windows cuda 11.6 changes Windows cuda 11.6 changes Mar 22, 2022
malfet
malfet approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please get rid of .bat files (or somehow get rid of repeated code and use more functional like programming)

@atalman
Copy link
Contributor Author

atalman commented Mar 23, 2022 •
edited

LGTM, can you please get rid of .bat files (or somehow get rid of repeated code and use more functional like programming)

Will Do, will post another PR to refactor this code!

@atalman atalman merged commit cea2213 into pytorch:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atalman @malfet @facebook-github-bot