Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests from domains on our CI #69

Closed
ejguan opened this issue Oct 18, 2021 · 4 comments
Closed

Run tests from domains on our CI #69

ejguan opened this issue Oct 18, 2021 · 4 comments

Comments

@ejguan
Copy link
Contributor

ejguan commented Oct 18, 2021

per title.
This would help us to notify domains about the BC breaking changes.

Reference:

cc: @NivekT

@Nayef211
Copy link

Here is a list of datasets that have been implemented in torchtext (I will keep this list updated as we migrate more datasets from torchdata):

@pmeier
Copy link
Contributor

pmeier commented Nov 3, 2021

I'm currently adding tests for the torchvision datasets in pytorch/vision#4682. When this is merged, I'll update

- name: Run torchvision datasets tests
run: pytest --no-header -v vision/test/test_prototype_datasets.py

to run them.

@ejguan
Copy link
Contributor Author

ejguan commented Nov 3, 2021

@pmeier
Thanks!

facebook-github-bot pushed a commit that referenced this issue Nov 5, 2021
Summary:
Addresses #69 for `torchvision`. Note that the workflow will fail for another ~24 hours, since pytorch/vision#4682 will only then be included in the nightly release.

Pull Request resolved: #96

Reviewed By: wenleix

Differential Revision: D32171429

Pulled By: ejguan

fbshipit-source-id: 3b5cd0a56bbcc86672a62d047e4491a433811d6a
@ejguan
Copy link
Contributor Author

ejguan commented Apr 18, 2022

Closing the issue as we have domain referencing the DataPipe utilization in vision/test/audio domains

@ejguan ejguan closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants