Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Remove dependency to torch 1.5.0 nightly when 1.5.0 releases #39

Closed
1 of 11 tasks
kiukchung opened this issue Jan 27, 2020 · 0 comments
Closed
1 of 11 tasks

Remove dependency to torch 1.5.0 nightly when 1.5.0 releases #39

kiukchung opened this issue Jan 27, 2020 · 0 comments

Comments

@kiukchung
Copy link
Contributor

kiukchung commented Jan 27, 2020

🐛 Bug

Currently torchelastic-0.1.0rc2 (trunk) depends on torch nightly to use EtcdStore instead of the TCPStore. The following two things need to happen when torch 1.5.0 releases:

  1. In requirements.txt change the dependency to torch>1.4.0 to torch>=1.5.0
  2. Edit .circleci/config.yml#install_dep target to remove the manual install of torch nightly

Known workarounds

  • Manually install torch nightly (1.5.0.dev+). For more details see https://pytorch.org/
    • conda (cpu or gpu)
      conda install pytorch torchvision -c pytorch
      
    • pip (cpu)
       pip install --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
      
    • pip(gpu)
       pip install --pre torch torchvision -f https://download.pytorch.org/whl/nightly/cu101/torch_nightly.html
      
  • Then install torchelastic (where ~/elastic is the repo root)
    cd ~/elastic
    python setup.py install
    -- or --
    pip install -e ~/elastic
    

Component (check all that applies):

  • state api
  • train_step api
  • train_loop
  • rendezvous
  • checkpoint
  • rollback
  • metrics
  • petctl
  • examples
  • docker
  • other

To Reproduce

N/A

Expected behavior

python setup.py test should pass all tests

Environment

  • torchelastic version (e.g. 0.1.0rc1): 0.1.0rc2
  • OS (e.g., Linux): Linux
  • How you installed torchelastic (conda, pip, source, docker): from source
  • Docker image and tag (if using docker):
  • Build command you used (if compiling from source):
  • Git commit (if installed from source):
  • Python version:
  • CUDA/cuDNN version:
  • GPU models and configuration:
  • Execution environment (on-prem, aws, etc):
  • Any other relevant information:

Additional context

See
#37
#34

facebook-github-bot pushed a commit that referenced this issue Jun 9, 2021
Summary:
Pull Request resolved: pytorch/torchx#39

The diff merges Container and Role together to make torchx APIs simler. The diff also modifies consumers of the torchx lib.

Reviewed By: d4l3k, wilson100hong

Differential Revision: D28915998

fbshipit-source-id: e7a4702c1c4039f1caa0823da8a7f8db7278a248
fotstrt pushed a commit to eth-easl/elastic that referenced this issue Feb 17, 2022
Summary:
Pull Request resolved: pytorch/torchx#39

The diff merges Container and Role together to make torchx APIs simler. The diff also modifies consumers of the torchx lib.

Reviewed By: d4l3k, wilson100hong

Differential Revision: D28915998

fbshipit-source-id: e7a4702c1c4039f1caa0823da8a7f8db7278a248
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant